Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process queries in prepared statements in binary protocol (pgsql) #280

Merged
merged 3 commits into from
Nov 7, 2018
Merged

process queries in prepared statements in binary protocol (pgsql) #280

merged 3 commits into from
Nov 7, 2018

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Nov 7, 2018

noticed that now we don't process queries from prepared statements in binary protocol to postgresql with acra-censor (decryption worked before)
but can't add good integration tests now, because python hasn't good libraries to work with postgresql with binary protocol. psycopg2 (most popular) use text protocol for prepared statements (that we test too). found asyncpg, but tests with it unstable in my local environment (tests fail on closing connection or unexpected empty result without any errors)

now tested it manually before push and check that branch of fetching query from Parse packet works as expected and leave tests with asyncpg which can be used by commenting self.skipTest in checkSkip function

@vixentael
Copy link
Collaborator

Neat!
Could you please check prepared statements for MySQL as well?

@Lagovas
Copy link
Collaborator Author

Lagovas commented Nov 7, 2018

checked and fixed too

@Lagovas Lagovas merged commit bac9ad0 into cossacklabs:master Nov 7, 2018
@Lagovas Lagovas deleted the lagovas/add-parse-packet-support branch November 12, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants