add jaeger auth params #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lagovas
commented
Oct 29, 2018
- add usename\password for basic auth for jaeger exporters. refactor jaeger params. register and fetch jaeger params with same method for all parts that use jaeger
- split tests. test mysql and postgresql separately. it decrease time of tests (from ~30 min to 18-20)
- some improvements in tests (explicitly set timeout for unix sockets)
- re-generate configs
vixentael
reviewed
Oct 29, 2018
| - postgresql | ||
| - mysql | ||
| # has errors with tls connections |
There was a problem hiding this comment.
yeah. tried mariadb docker container as is and took ssl error with an incompatible version (old ssl version on mariadb side, maybe it is default setting in image or something else...). next time will spend more time to understand what is wrong and add to tests
vixentael
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.