optimizations/refactoring #299
Conversation
…ing to octal escaped format
use trace options from config correct client_id logging unify proxy interfaces use factories extend decryptor
| @@ -143,9 +143,15 @@ func (ex *WriteToFileExecutor) Execute(data []byte) { | |||
|
|
|||
| // Close file | |||
| func (ex *WriteToFileExecutor) Close() { | |||
| if *host != cmd.DEFAULT_ACRA_HOST || *port != cmd.DEFAULT_ACRASERVER_PORT { | ||
| *acraConnectionString = network.BuildConnectionString("tcp", *host, *port, "") | ||
| config.SetAcraConnectionString(network.BuildConnectionString("tcp", *host, *port, "")) |
cmd/acra-server/acra-server.go
Outdated
| poisonCallbacks.AddCallback(base.NewExecuteScriptCallback(*scriptOnPoison)) | ||
| config.scriptOnPoison = *scriptOnPoison | ||
| } | ||
| // must be last |
There was a problem hiding this comment.
"must be last" in terms of setting poison callbacks?
maybe it makes sense to change to "should setup "stopOnPoison" as last poison record callback"
decryptor/base/dataProcessor.go
Outdated
| } | ||
|
|
||
| // WithZoneID replace ZoneID and return itself | ||
| func (ctx *DataProcessorContext) WithZoneID(id []byte) *DataProcessorContext { |
There was a problem hiding this comment.
I would expect that ctx.WithZoneID() will return new copy of itself with selected ZoneID. Maybe it's only me, but maybe it makes sense to rename method to SetZoneID / UpdateZoneID? To make clear that it returns the same context, just ZoneID updated.
decryptor/base/dataProcessor.go
Outdated
| } | ||
|
|
||
| // WithContext replace context and return itself | ||
| func (ctx *DataProcessorContext) WithContext(newContext context.Context) *DataProcessorContext { |
| @@ -128,7 +128,7 @@ func (packet *MysqlPacket) replaceQuery(newQuery string) { | |||
|
|
|||
| // readPacket read header to struct and return payload as return result or error | |||
| func (packet *MysqlPacket) readPacket(connection net.Conn) ([]byte, error) { | |||
| if _, err := connection.Read(packet.header); err != nil { | |||
| if _, err := io.ReadFull(connection, packet.header); err != nil { | |||
There was a problem hiding this comment.
helper read more than once (if first read call was not full and return only part of data cached in os buffer). until some error or until no data was returned. ReadFull read in loop until read expected num of bytes. I meet one failed test when here read return part of packet and without error
| ) | ||
|
|
||
| var lock = sync.RWMutex{} |
Co-Authored-By: Lagovas <lagovas.lagovas@gmail.com>
Co-Authored-By: Lagovas <lagovas.lagovas@gmail.com>
Co-Authored-By: Lagovas <lagovas.lagovas@gmail.com>
…vas/acra into lagovas/open-source-version
As I remember, I didn't change any public CLI or API interfaces that should be changed in documentation. And didn't change any behavior of server. Touched only some log messages (uppercase or change level from DEBUG to INFO)