Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type awareness in timescaledb demo #50

Merged
merged 5 commits into from
May 27, 2022

Conversation

G1gg1L3s
Copy link
Contributor

@G1gg1L3s G1gg1L3s commented Apr 17, 2022

This PR enables type awareness support for a device and unit_id fields or cpu_temp table. It also fixes grafana to use TLS so the Acra can correctly decrypt the records.

UPDATE: fixed There is one issue though. The readme says that the grafana for demo data should look like: ![image](https://user-images.githubusercontent.com/43041209/163715887-db2a50c5-aa01-4f7f-abbf-58dbea0051e4.png)

But in my case it looks like:
image

I guess that's because the unit_id became an int, so grafana interprets it as a numerical value and draws a bar of its height. Don't really know how to fix it, so I hope you will help.

Also, please check if maybe I missed something.

@@ -161,6 +161,8 @@ services:

grafana:
image: grafana/grafana:8.3.0
# Dirty hack: run as root to deal with permissions
user: root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

I don't know when docker-compose started to use `-` instead of `_`
for container names but here we are.
This will fix a problem with incorrect rendering of bars in grafana.
It could be fixed with `::text` sql conversion, but the Acra doesn't
support it yet.
Copy link
Contributor

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge after releasing

@Lagovas Lagovas merged commit a160f7d into master May 27, 2022
@Lagovas Lagovas deleted the G1gg1L3s/T2532-use-type-awareness branch May 27, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants