Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update home page design #2374

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

yasell
Copy link
Contributor

@yasell yasell commented Apr 25, 2024

This PR updates the style and design of the home page.

@yasell yasell requested review from mtardy and a team as code owners April 25, 2024 08:11
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 6bbb6c2
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/665ef43566411800087b6d0b
😎 Deploy Preview https://deploy-preview-2374--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks way better, especially since we switched logos!

I needed to remove a lot of the custom style because Docsy had a breaking change moving to Bootstrap 5 in v0.7.0 and most of the style written was broken https://github.com/google/docsy/releases/tag/v0.7.0. I hope this time, this is more resilient for future updates.

I have a few first comments, but I think this PR should be a draft given you have a lot of placeholders and links that don't work on the page, so I'll convert it to draft as of now, you can mark it ready once you want a full review.

I would say as long as the homepage doesn't affect how the rest of the documentation looks (typically the global font change isn't great) I'm super fine with it and happy that someone who can write serious design and CSS rewrote that.

docs/assets/scss/_variables_project.scss Outdated Show resolved Hide resolved
docs/static/images/home/hero-illustration.png Outdated Show resolved Hide resolved
docs/layouts/partials/footer.html Show resolved Hide resolved
@mtardy mtardy marked this pull request as draft April 25, 2024 09:04
@mtardy mtardy added release-note/docs This PR updates the documentation. area/documentation Improvements or additions to documentation labels Apr 25, 2024
@xmulligan
Copy link
Member

Sorry I know this is a little late in the process, but can we had a section like the one below to the website under the first section? "We are a proud CNCF project"

Some people don't realize this and it would be great to get on the website

Screenshot 2024-05-08 at 10 31 46

@yasell yasell force-pushed the update-home-page branch 2 times, most recently from 7c85f18 to 086b82b Compare May 16, 2024 12:54
@mtardy
Copy link
Member

mtardy commented Jun 3, 2024

Just fyi, I updated Docsy and Hugo version, you might need to rebase on top of main (for that PR #2497). I checked, and nothing breaks on your homepage, you just need to merge some commits during the rebase but it should be trivial, just accept both changes all the time.

@mtardy mtardy self-requested a review June 3, 2024 10:20
@yasell yasell marked this pull request as ready for review June 3, 2024 11:15
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits into the first one maybe? thanks!!

docs/assets/scss/_variables_project.scss Outdated Show resolved Hide resolved
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to merge but I did some checks and found some issues! Again if you fix this, feel free to squash your commits into one. Thanks a lot, overall it's night and day with the current homepage.

docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
docs/content/en/_index.html Outdated Show resolved Hide resolved
Signed-off-by: Raman Yasel <raman.yasel@gmail.com>
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks fantastic! :)

@mtardy mtardy merged commit 7e8cfff into cilium:main Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants