awesome work. reviewing

I think you should add a selenium test. This is quite easy to do and will properly test it works.

This is dope. So yes, only thing missing is the selenium test that will ensure your tagHelpers and the
AddDataAnnotationsLocalization works as desired.

@NicolasDorier I have just committed the Selenium test but cannot run it myself. The selenium tests only run on Chrome 74, but I have 76. Not sure how to handle this.
Can you check again please?

I also did a major performance improvement: Previously each translate call would re-create the translator and read the JSON file again and again, causing very slow page load. No longer an issue.

@woutersamaey that's strange, you should be able to run the tests. I will check.

You also need to fix the warnings by the way.

Check https://circleci.com/gh/btcpayserver/btcpayserver/2281?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@NicolasDorier I'm seeing a lot of Address not available messages in CircleCI, but I don't think this has anything to do with this PR, am I right?

The warnings have been fixed.

The Selenium test still fails. Not sure why.
Since I can't debug (ChromeDriver version issue) it's hard to proceed from here. Any ideas so far?

Ignore Address not available.

@NicolasDorier Where do you suggest I put it?

I can put it in the footer if you prefer that, but in that case I'll make sure to add automatic language detection based on the Accept header since the switcher won't be as visible as below the fold for most users.

Pulled the code and it is working! Tnx for your help!

@woutersamaey idea: (fa-globe)

@NicolasDorier I like the minimalistic presentation, but don't think the globe is well recognized for translation.

Why not keep the dropdown but with:

• The language code EN / NL as labels
• Use CSS to make the <select> blend with the background so you can only see the 2 letter label (no white background, no border, uppercase)

I prefer to keep the dropdown as it triggers a form HTTP POST + it is convenient on mobile devices thanks to native input controls.

Having a traditional menu dropdown or a pop-up modal would be a problem once we get like 40 languages.

If you think changing the CSS is sufficient, I would prefer to keep the languages names in full form and not 2 letter codes. Maybe add a separator on the left, that could also help set it aside from the main menu.

What do you think?

I am not good in html/css but I think that you can make the globe (or any other logo you like in font awesome) show a dropdown when clicked without javascript.

Having a traditional menu dropdown or a pop-up modal would be a problem once we get like 40 languages.

We'll see what do to when we get to this point. Though I don't think this is problematic.

If you think changing the CSS is sufficient, I would prefer to keep the languages names in full form and not 2 letter codes. Maybe add a separator on the left, that could also help set it aside from the main menu.

Whatever, but it should not take too much screen space as it is rare people use it once they have set their location. Another idea is to put this in the User profile.

You can browse icons on https://fontawesome.com/icons

Maybe in the footer it can also work.

@NicolasDorier I'll do a combination of what you suggested.

Full dropdown in footer (best to keep this for older people) + globe icon on top.

You're right about the dropdown without JavaScript and I am familiar with FontAwesome. This is kinda my thing 👍

@woutersamaey please rebase. We will use the current dropbox only in regtest (hidding it on mainnet) until you can replace it with something better.

Will do. Please give me 1-2 days. My holiday is over and I'm back at work so busier again :(

Unfortunately I'm not finding the time to continue work on this. I got pretty far, but lacking the time to finish.
If someone could help out to push this though, I'd be very grateful.
I'm free to do a call if it helps.

Will take it upon myself to finish this as soon as I'm free

I'll take this over... will close it temporarily as we clean up our PRs (gotta reach 0 @NicolasDorier). Will rebase and merge existing effort as soon as I have time.

Reopening to reconsider