Add showRMS preference #6220
Open
Add showRMS preference #6220
+36
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
though on second thought, I probably should have modified something in WaveformView so we can save a bunch of rectangle drawing calls. Maybe +if(mShowRMS) {
dc.SetPen(muted ? muteRmsPen : rmsPen);
for (int x0 = 0; x0 < rect.width; ++x0) {
int xx = rect.x + x0;
if (r1[x0] != r2[x0]) {
AColor::Line(dc, xx, rect.y + r2[x0], xx, rect.y + r1[x0]);
}
}
+}when all you look at is colors, every problem is just a color change away, I suppose :) |
| @@ -101,13 +102,15 @@ void TrackArtist::SetColours( int iColorIndex) | |||
| theTheme.SetBrushColour( beatWeakBrush, clrBeatFillWeakBrush ); | |||
| theTheme.SetBrushColour( beatStrongSelBrush, clrBeatFillStrongSelBrush ); | |||
| theTheme.SetBrushColour( beatWeakSelBrush, clrBeatFillWeakSelBrush ); | |||
|
|
|||
|
|
|||
| mShowRMS = gPrefs->Read(wxT("/GUI/ShowRMS"), mShowRMS); | |||
There was a problem hiding this comment.
See examples of BoolSetting. Avoid new string literals for preferences repeated in various places.
| auto &commandManager = CommandManager::Get( project ); | ||
| auto &trackPanel = TrackPanel::Get( project ); | ||
|
|
||
| bool checked = !gPrefs->Read(wxT("/GUI/ShowRMS"), true); |
There was a problem hiding this comment.
Use BoolSetting::Toggle instead
There was a problem hiding this comment.
do I do the same to the ShowClipping and ShowTrackNameInWaveform preferences right next door as well?
There was a problem hiding this comment.
I’m preparing a contribution to clean that up. So you done have to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6219
Another feature cherrypick from my themes branch