Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed indicator now remains visible #6202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speed indicator now remains visible #6202

wants to merge 1 commit into from
+3 −1

Conversation

pedrofpclima
Copy link

Resolves: #6032

When shrunk to near absolute minimum, the audio clip's speed indicator would disappear. This is not the case anymore, as the lowest stretch ratio is now set to 100 / (double)99999. Such change ensures that the clip's speed never exceeds 99999%.

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@pedrofpclima
Fix audacity#6032: Speed indicator now remains visible.
d05e60e 
When shrunk to near absolute minimum, the audio clip's speed indicator would disappear.
This is not the case anymore, as the lowest stretch ratio is now set to 100 / (double)99999.
Such change ensures that the clip's speed never exceeds 99999%.
@LWinterberg
Copy link
Member

I have two comments on this:

Firstly, this creates a situation where a clip never can be made shorter than that. My gut feeling says that's fine - we're running into the issue that clips which are too short really struggle during playback anyway. I'd still hear @saintmatthieu's thought on the matter though.

Secondly, this fix causes a bug @pedrofpclima

  1. Using Alt+drag on the edge, drag the clip to 99999%
  2. Still holding alt+drag, continue dragging the clip shorter
  3. Let go of the clip
  4. Using alt+drag on the edge again, try to expand the clip/slow it down

In this case, dragging is unresponsive by as many pixels as you overshot in step 2. I suspect that you need to clamp another value somewhere else as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintmatthieu saintmatthieu Awaiting requested review from saintmatthieu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When shrunk to almost absolute minimum, audio clip has no longer stretch ratio indication in its title bar
2 participants
@pedrofpclima @LWinterberg