Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] upgrade webapp angular deps version #1707 #1987

Merged
merged 29 commits into from
Jun 12, 2024
Merged

[feature] upgrade webapp angular deps version #1707 #1987

merged 29 commits into from
Jun 12, 2024

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented May 14, 2024

What's changed?

link #1707

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Aias00
Merge branch 'master' into feature/upgrade_webapp
50005c3 
Signed-off-by: aias00 <rokkki@163.com>
@tomsun28
Copy link
Contributor

hi thanks👍 lgtm, this involves a major front-end version upgrade, but we are releasing a new version.
Please wait it will take some days to merge.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 14, 2024
@tomsun28 tomsun28 self-requested a review May 14, 2024 08:43
@Aias00
Copy link
Contributor Author

Aias00 commented May 14, 2024 via email

@tomsun28 tomsun28 added this to the 1.6.1 milestone May 24, 2024
yykaue
yykaue approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@yykaue yykaue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade webapp angualr delon ngzorro alain version to 17 latest

tomsun28
tomsun28 previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！thanks.

@tomsun28
Copy link
Contributor

hi, i try to login the console, the error happen. It seems the this.reuseTabService is null.

login.component.ts:138 ERROR TypeError: Cannot read properties of null (reading 'clear')
    at Object.next (login.component.ts:145:30)
    at ConsumerObserver.next (Subscriber.js:91:33)
    at SafeSubscriber._next (Subscriber.js:60:26)
    at SafeSubscriber.next (Subscriber.js:31:18)
    at subscribe.innerSubscriber (switchMap.js:14:144)
    at OperatorSubscriber._next (OperatorSubscriber.js:13:21)
    at OperatorSubscriber.next (Subscriber.js:31:18)
    at map.js:7:24
    at OperatorSubscriber._next (OperatorSubscriber.js:13:21)
    at OperatorSubscriber.next (Subscriber.js:31:18)

tomsun28
tomsun28 reviewed Jun 12, 2024
View reviewed changes
web-app/package.json Outdated Show resolved Hide resolved
@Aias00
Copy link
Contributor Author

Aias00 commented Jun 12, 2024

hi, i try to login the console, the error happen. It seems the this.reuseTabService is null.

login.component.ts:138 ERROR TypeError: Cannot read properties of null (reading 'clear')
    at Object.next (login.component.ts:145:30)
    at ConsumerObserver.next (Subscriber.js:91:33)
    at SafeSubscriber._next (Subscriber.js:60:26)
    at SafeSubscriber.next (Subscriber.js:31:18)
    at subscribe.innerSubscriber (switchMap.js:14:144)
    at OperatorSubscriber._next (OperatorSubscriber.js:13:21)
    at OperatorSubscriber.next (Subscriber.js:31:18)
    at map.js:7:24
    at OperatorSubscriber._next (OperatorSubscriber.js:13:21)
    at OperatorSubscriber.next (Subscriber.js:31:18)

hi, this error has bee sloved

tomsun28
tomsun28 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! it works. 👍 Thanks for contribution.

@tomsun28
Copy link
Contributor

close #1707

@tomsun28 tomsun28 merged commit 009a512 into apache:master Jun 12, 2024
3 checks passed
@tomsun28 tomsun28 mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yykaue yykaue yykaue approved these changes

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
good first pull request Good for newcomers wait for process webapp
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aias00 @tomsun28 @yykaue