Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32088][checkpoint] Space control in file merging #24807

Merged
merged 1 commit into from
May 30, 2024
Merged

[FLINK-32088][checkpoint] Space control in file merging #24807

merged 1 commit into from
May 30, 2024

Conversation

Zakelly
Copy link
Contributor

@Zakelly Zakelly commented May 17, 2024 •
edited

What is the purpose of the change

As we know, the checkpoint file merging will introduce space amplification. This PR introduce a space control in file merging, by rewriting old files and eliminate the empty slot on underlying files.

Brief change log

  • Space accounting and flags in file merging manager and physical files.
  • Rewrite in RocksdbStateBackend

Verifying this change

Added UTs for file merging manager.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented May 17, 2024 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly Zakelly force-pushed the f32088 branch 5 times, most recently from cbb2f56 to 2e8ea70 Compare May 26, 2024 16:45
masteryhx
masteryhx reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Overall LGTM.

flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java Outdated Show resolved Hide resolved
...ain/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java Outdated Show resolved Hide resolved
masteryhx
masteryhx approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@masteryhx masteryhx left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
LGTM.

@Zakelly
Copy link
Contributor Author

Zakelly commented May 28, 2024

@flinkbot run azure

Zakelly added a commit to Zakelly/flink that referenced this pull request May 29, 2024
@Zakelly
[FLINK-32088][checkpoint] Space control in file merging
82905cc 
This fixes apache#24807
@Zakelly
Copy link
Contributor Author

Zakelly commented May 29, 2024

Rebased to resolve conflicts

@Zakelly Zakelly merged commit 6ee3094 into apache:master May 30, 2024
@Zakelly Zakelly deleted the f32088 branch May 30, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masteryhx masteryhx masteryhx approved these changes

Assignees
No one assigned
Labels
component=Runtime/Checkpointing component=Runtime/StateBackends
Projects
None yet
Milestone
No milestone
3 participants
@Zakelly @flinkbot @masteryhx