Fix redirect functionality for redirect_non_whitelisted_config value #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this firewall package for a while. Thank you!!! Today for the first time, I had a use case where I needed to assign a url to redirect_non_whitelisted_to in my firewall config. After doing so, I noticed the redirect was not working for non-whitelisted users. It returned the http response code defined in the responses.whitelist config value but was completely ignoring the redirect_non_whitelisted_to config value.
I investigated further and noticed a refactor at commit 075b69b, which appears to have removed the condition to check the value of redirect_non_whitelisted_to. I refactored the Whitelist filter function a little bit to fix this.