-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulator: don't bind to external IP during DNS simulations #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmroz
force-pushed
the
issues/39
branch
2 times, most recently
from
September 10, 2021 05:51
489e76a
to
fd1fc36
Compare
Added Sample output/errors: Default iface
iface set by user (ubuntu, with 127.0.0.53 in /etc/resolv.conf
|
Something like this... let me know what you guys think. As discussed, we can hold off on this until the next release, in which case I'll prep a release tomorrow.
|
tg
reviewed
Oct 26, 2021
Extend how flightsim finds a usable (up until now, only external) IP. An external IP is favoured, however, allow flightsim to fallback to a local/internal IP if necessary. This will correctly show failures in IP simulations if a user specifies '-iface lo'. For DNS simulations using systemd's stub resolver, this will allow the simulation to succeed. Further, DNS simulations should use the interface obtained via a DNS probe, unless overridden via the -iface flag.
🦭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with DNS queries where the nameserver is not reachable via
the external IP (ie. systemd's 127.0.0.53, etc).
Also report an error if resolve fails due to dial errors.
Addresses: #39