Create BankAccount entitied from valid IBANs #503
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Mentionsseem to be missing, ingestigateAs per #415 and #2066, this is an attempt to create
BankAccountFTM entities out of valid IBANs.In the analysis stage, an IBAN is identified by the existing regex. It is added to the list of Mentions.
Then, the IBANs that have been collected as Mentions are validated using schwifty. openiban was also considered, but it performs worse than
schwifty. I've listed some test cases below.BankAccountentities are created for each valid IBAN, and the IBAN string is added to theibanFTM attribute.When running Aleph locally, after I ingested a test document (attached here), the BankAccount FTM entities appear in FTM-store, but they don't show up in the Aleph UI. This should be investigated further.
Workaround: re-index the investigation containing the IBANs document. Then, go to Entities (in the sidebar) > Add a new entity type > Bank Account. The newly created entities will appear in the table. They do not appear in the sidebar, though.
IBANs.pdf