Fix DB Clean plugin new devices deletion bug #498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in this refactor commit which caused the DB cleaning script to delete all new devices even if the configuration parameter
hourstokeepnewdevice
has a value of0
.The cause is that before the refactor the parameters of the function cleanup_database were integer values, however after the refactor they are string values, causing this issue and potentially other unexpected behaviors.
This may be related to #474 and #481