Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in PIHOLE plugin #479

Closed
ftrueck opened this issue Oct 12, 2023 · 4 comments
Closed

Issues in PIHOLE plugin #479

ftrueck opened this issue Oct 12, 2023 · 4 comments
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.

Comments

@ftrueck
Copy link

ftrueck commented Oct 12, 2023

The plugin PIHOLE crashes the whole docker container, when the config is not correct.

Example:

  • pihole-FTL.db does not exist and plugin is enabled => Docker container crashes
  • The SQL Query for pihole is missing a check on the end of the query => AND na.ip <> null;
  • The plugin is configured to run once and conditions 1 or 2 are met => Docker container crashes few seconds after boot up
@jokob-sk jokob-sk mentioned this issue Oct 12, 2023
Merged
@jokob-sk
Copy link
Owner

Hi @ftrueck

Thanks for the question.

  • pihole-FTL.db does not exist and plugin is enabled => Docker container crashes

Thi sis expected behavior as I can't influence how the user configures their docker environment. I could check if the file exists, but I would even say that it would hide the issue and users this way fix their mappings earlier. Happy to hear your thoughts.

Cheers,
j

@jokob-sk jokob-sk added the bug 🐛 Something isn't working label Oct 12, 2023
@ftrueck
Copy link
Author

ftrueck commented Oct 12, 2023

I suggest to gracefully fail instead of exiting the whole application. In case of misconfiguration it would help if the container is not crashing, because not everyone knows how to shell into the container to fix the config file manually.

@jokob-sk
Copy link
Owner

good point on chnaging the configuration after the crash - will have a look into it as well

jokob-sk added a commit that referenced this issue Oct 13, 2023
@jokob-sk
Docs + Device list rework v0.3 + #479 work 🔨
257e46d
jokob-sk added a commit that referenced this issue Oct 13, 2023
@jokob-sk
#479 work 🔨
f3b6474
@jokob-sk jokob-sk added the next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. label Oct 13, 2023
@jokob-sk jokob-sk mentioned this issue Oct 15, 2023
Closed
@jokob-sk
Copy link
Owner

Released in 23.11.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ftrueck @jokob-sk