-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Devices stopped showing in "all devices" or "connected" due to IPv6 validation failing #523
Comments
Hi @jsmith432! Can you try to check if there are any javascript errors in the browser dev tools? General steps are described here: https://github.com/jokob-sk/Pi.Alert/blob/main/docs/DEBUG_INVALID_JSON.md Could you please also check that accessing the API endpoint Thanks, |
Thanks for that! I think one of the plugins is passing incorrect data to the main app (where the app expects an IP). Can you please check the plugin data returned by the plugins you enabled in the UI under Plugins? For example for PIHOLE: https://github.com/jokob-sk/Pi.Alert/blob/main/docs/img/DEBUG_PLUGINS/plugin_objects_pihole.png |
Thanks for that! There might be more work required to get full v6 support, but I fixed that one function. The fix can be tested in the |
Thanks for checking @jsmith432 ! I made the ip/ipv6 check more forgiving and only logged an error in the console instead of throwing an exception. I also account for different length ipv6 addresses (the previous code didn't handle ipv4 mapped to ipv6 formats (I don't use IPv6 and this is all new to me 😅). If you could test the Thanks in advance, |
Thank you. I can see the list of devices now. Here is the thing, though. I don't "use" ipv6. I have it disabled on my router and pi-hole. But somehow, Pi-hole is reading from the devices when they connect. I didn't research how that all works. |
Ah glad to hear things work again. I could probably filter out ipv6 import from PiHole but not sure if that's a desired behavior for other users. Anyway, let's see what people say after the next release and I'll adjust accordingly. Thanks for the help, I think this issue should then be solved, yes? |
@eitch Could you please try a different browser? The file might be cached. |
You are right! Thanks! |
I can confirm I have several ipv6 devices on my network and the console was showing invalid ip address format - I was running 2023-12-21 It is working for me now though, so thanks! |
Released -> Closing |
Devices stopped showing in "all devices" or "connected"
I am past the 100 devices, not sure if that triggered something but I cannot see the devices anymore on the devices tab.
The text was updated successfully, but these errors were encountered: