lang: Added Hungarian translations #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't this change already in this PR ? |
I added the change yesterday, but I forgot to update the PR description. Everything should be ready to merge now. |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
ImHex didn't support Hungarian :(
Implementation description
I translated ImHex to Hungarian :)
Translation Coverage
Additional Notes
There are four Hungarian "special" characters that fall outside the default Unicode ranges loaded by ImHex, resulting in them being replaced with the "�" character. These letters are Ő (U+0150), ő (U+0151), Ű (U+0170) and ű (U+0171), all included in the Latin Extended-A Unicode block.
The easy fix for this is to include the "Unicode Latin Extended-A" range when loading the font glyphs in init_tasks.cpp:189. This change would also unlock the full character range of Bosnian, Croatian, Czech, Estonian, Latvian, Lithuanian, Maltese, Polish, Romanian, Slovak, Slovene and Turkish. I can add the commit to this PR if maintainers are okay with it. EDIT: Added a commit that loads Latin Extended-A by default.
Also note that some words are longer than their English counterparts, resulting in certain UI labels overflowing from their parent containers, and being cut off. I might change some of the longer labels to be more compact in the future, but the container size limitations will have to be addressed eventually (e.g. with horizontal scrollbars).