Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC1363 error signatures #5010

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Update ERC1363 error signatures #5010

merged 5 commits into from
Jun 4, 2024

Conversation

vittominacori
Copy link
Contributor

In order for the ERC1363 errors to adhere at EIP-6093, I changed from\to with sender\receiver as expressed in eip-6093#parameter-glossary.

Also added missing natspec comments for parameters as they were inserted for all the other errors.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024 •
edited

⚠️ No Changeset found

Latest commit: 35f5329

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vittominacori
Copy link
Contributor Author

@Amxx any updates?

@Amxx Amxx added this to the 5.1 milestone Apr 22, 2024
@Amxx Amxx added the documentation Inline comments, guides, and examples. label Apr 22, 2024
@vittominacori vittominacori force-pushed the feat/update-erc1363-error-signatures branch from ab4a759 to 0a2dc05 Compare June 3, 2024 16:53
ernestognw
ernestognw previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestognw ernestognw requested review from Amxx and cairoeth June 3, 2024 23:34
cairoeth
cairoeth reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@cairoeth cairoeth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, small nits for consistency

@ernestognw @cairoeth
Update contracts/token/ERC20/extensions/ERC1363.sol
42d99bf 
Co-authored-by: cairo <101215230+cairoeth@users.noreply.github.com>
@ernestognw @cairoeth
Update contracts/token/ERC20/extensions/ERC1363.sol
1bd7ca1 
Co-authored-by: cairo <101215230+cairoeth@users.noreply.github.com>
@Amxx Amxx merged commit 8a890ff into OpenZeppelin:master Jun 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

@ernestognw ernestognw ernestognw approved these changes

@cairoeth cairoeth cairoeth approved these changes

Assignees
No one assigned
Labels
documentation Inline comments, guides, and examples. ignore-changeset
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vittominacori @Amxx @ernestognw @cairoeth