LDAP protocol parser v2 #11087
Closed
LDAP protocol parser v2 #11087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation adds types and filters specified in the LDAP RFC to work with the ldap_parser. Although using the parser directly would be best, strange behavior has been observed during transaction logging. It appears that C pointers are being overwritten, leading to incorrect output when LDAP fields are logged.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11087 +/- ##
===========================================
+ Coverage 64.19% 80.53% +16.33%
===========================================
Files 847 926 +79
Lines 136684 251175 +114491
===========================================
+ Hits 87750 202276 +114526
+ Misses 48934 48899 -35
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
requested changes
May 24, 2024
| } | ||
| } | ||
|
|
||
| unsafe extern "C" fn rs_ldap_probing_parser( |
There was a problem hiding this comment.
we use a new style for these FFI functions SCLdapProbingParser (so the C-style).
|
Replaced with #11163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
(if applicable)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
Abandon Requestbecause apparently is not parsed correctly (see Abandon request not parsed correctly? rusticata/ldap-parser#6)