Add priority customization to request #2330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSB
reviewed
Feb 1, 2024
Sources/Moya/MoyaProvider.swift
Outdated
| return requestNormal(target, callbackQueue: callbackQueue, progress: progress, priority: priority, completion: completion) | ||
| } | ||
|
|
||
| public func request(_ target: Target, callbackQueue: DispatchQueue?, progress: ProgressBlock?, completion: @escaping Completion) -> Cancellable { |
There was a problem hiding this comment.
why this additional function?
does the function above with the new priority param with a default value not maintain API compatibility?
There was a problem hiding this comment.
@AndrewSB Old C++ habit ! I fixed it.
8c98fc1
to
0e0ce18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨
I would like to be able to set the NSURLSessionTask's priority.
This PR adds a parameter to do that, with a default value to avoid breaking changes.
Current proposal does not allow yet to change the priority dynamically after the request is created.
I targeted the main branch because it looks like develop is outdated and I tried to avoid making breaking changes.
Fixes #2174