Add option to stop discovery when predefined lights are found (base branch es2015) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## es2015 #61 +/- ##
==========================================
+ Coverage 58.41% 59.13% +0.72%
==========================================
Files 50 50
Lines 1688 1713 +25
Branches 255 259 +4
==========================================
+ Hits 986 1013 +27
+ Misses 702 700 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used a prototype version of this implementation for quite some time to avoid lights dropping out occasionally in my node-red home automation setup.
If for example below settings are passed to client on init, the discovery process will stop after the listed lights have been discovered. This prevents discovery processing setting lights offline if they don't respond for some reason. I've found this does not necessarily prevent packets being processed on the lights.
Client will emit
discovery-completedafter the lights are found if the configuration option is enabled.This PR is done against the base branch es2015 like my earlier PR #60 from today.