Small Compiler fix #417
Open
Small Compiler fix #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't approve this for a couple of reasons.
If you clean the git stuff up, it should be good (once I confirm with a bit of testing)! |
|
My apologies, ill remove this pull request and properly format it before
submitting it again. Thank you
…On Sat, Jul 29, 2023, 4:43 PM Jack McDowell ***@***.***> wrote:
I can't approve this for a couple of reasons.
1. Looks like you somehow messed up the submodules - their files are
being considered part of BLUESPAWN, which shouldn't be the case. Make sure
they're still submodules and not just repos dumped in bluespawn's source
directories.
2. I'm seeing a lot of source files being recorded as completely
changed when they're not really being touched. That screws up git history.
I'm guessing you swapped tabs for spaces or something.
3. Changes like this should go into develop, not master. We keep
master pointing to the latest version of release code.
If you clean the git stuff up, it should be good (once I confirm with a
bit of testing)!
—
Reply to this email directly, view it on GitHub
<#417 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWZHHQNHK63TVUMU4J6RK63XSWN3NANCNFSM6AAAAAA2G5EBOU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluespawn.cpp changes:
catch(const std::exception& e) {
Bluespawn::io.InformUser(StringToWidestring(options.help()));
LOG_ERROR(e.what());
Eventlog.cpp changes:
// Open the channel config
EventWrapper hChannel{ EvtOpenChannelConfig(NULL, channel.c_str(), 0) };
if(reinterpret_cast(NULL) == hChannel) {
LOG_ERROR(L"EventLogs::IsChannelOpen: EvtOpenChannelConfig failed with " + std::to_wstring(GetLastError()) +
L" for channel " + channel);
return false;
}