-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft]feat: refactor Lock and Projection #180
Closed
kubeJocker
wants to merge
11
commits into
vitess-release-16.0-dev
from
feature/refactor-Lock-and-Projection
Closed
[draft]feat: refactor Lock and Projection #180
kubeJocker
wants to merge
11
commits into
vitess-release-16.0-dev
from
feature/refactor-Lock-and-Projection
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeJocker
changed the title
feat: refactor Lock and Projection
[draft]feat: refactor Lock and Projection
Jul 4, 2023
kubeJocker
force-pushed
the
feature/refactor-Lock-and-Projection
branch
from
July 12, 2023 08:11
4da7a3f
to
c236750
Compare
earayu
reviewed
Jul 12, 2023
} | ||
} | ||
reservedID := info.reservedID | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to check lockName must be literal in planner stage
@@ -233,6 +246,9 @@ func (stc *ScatterConn) ExecuteMultiShard( | |||
alias = state.TabletAlias | |||
}) | |||
} | |||
if reservedID != 0 { | |||
setLockSession(send, innerqr, session, queries[i].BindVariables, rs.Target, reservedID, alias) | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel it's a good idea to reserve a connection in case nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #106
fix #108
fix #143