Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wazuh-dashboard docker entrypoint script should use exec when starting the application #892

Open
mlaaksonen-csc opened this issue Jul 17, 2023 · 1 comment
Open

wazuh-dashboard docker entrypoint script should use exec when starting the application #892

mlaaksonen-csc opened this issue Jul 17, 2023 · 1 comment
Assignees
@vcerenu
Labels
community

Comments

@mlaaksonen-csc
Copy link

Currently wazuh-dashboard docker entrypoint script starts the actual application without exec'ing which has the side effect that any signals (HUP, TERM, INT) sent to the container are not passed to the application.

The fix is pretty trivial, just add exec in front of the last command (actual application to be run) in the entrypoint.sh script:

--- a/build-docker-images/wazuh-dashboard/config/entrypoint.sh
+++ b/build-docker-images/wazuh-dashboard/config/entrypoint.sh
@@ -17,4 +17,5 @@ echo $DASHBOARD_PASSWORD | $INSTALL_DIR/bin/opensearch-dashboards-keystore add o
 
 /wazuh_app_config.sh $WAZUH_UI_REVISION
 
-/usr/share/wazuh-dashboard/bin/opensearch-dashboards -c /usr/share/wazuh-dashboard/config/opensearch_dashboards.yml
\ No newline at end of file
+exec /usr/share/wazuh-dashboard/bin/opensearch-dashboards -c /usr/share/wazuh-dashboard/config/opensearch_dashboards.yml
+
@vcerenu vcerenu self-assigned this Jul 18, 2023
@vcerenu
Copy link
Member

vcerenu commented Jul 18, 2023

Hello @mlaaksonen-csc

Thank you very much for the correction, we will review it to add it in a future version.

I still encourage you to create your own PR to be able to add your change to the repository. If you are interested in adding your own commit, I recommend that you do it on branch 4.4 of our repository and sign your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcerenu vcerenu

Labels
community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlaaksonen-csc @vcerenu