Double equality used within single square brackets in build script #1273
Assignees
Comments
|
Hello. In bash, I tested this behavior in my machine and no difference was found: The test, set -x
FILEBEAT_TEMPLATE_BRANCH=5.0.0
WAZUH_MASTER_VERSION="$(curl -s https://raw.githubusercontent.com/wazuh/wazuh/master/src/VERSION | sed -e 's/v//g')"
echo "${WAZUH_MASTER_VERSION}"
if [ "${FILEBEAT_TEMPLATE_BRANCH}" = "${WAZUH_MASTER_VERSION}" ]; then
echo "They're equal"
else
echo "They're not equal"
fiFirst execution, with $ bash test.sh
+ FILEBEAT_TEMPLATE_BRANCH=5.0.0
++ curl -s https://raw.githubusercontent.com/wazuh/wazuh/master/src/VERSION
++ sed -e s/v//g
+ WAZUH_MASTER_VERSION=5.0.0
+ echo 5.0.0
5.0.0
+ '[' 5.0.0 == 5.0.0 ']'
+ echo 'They'\''re equal'
They're equalSecond execution, with $ bash test.sh
+ FILEBEAT_TEMPLATE_BRANCH=5.0.0
++ curl -s https://raw.githubusercontent.com/wazuh/wazuh/master/src/VERSION
++ sed -e s/v//g
+ WAZUH_MASTER_VERSION=5.0.0
+ echo 5.0.0
5.0.0
+ '[' 5.0.0 = 5.0.0 ']'
+ echo 'They'\''re equal'
They're equalAnyway, we will discuss this with the team and see if we need to change the operator or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had to update the build script, replace double equality with single on line 57 to get it to run. Otherwise comparison of equal string variables containing the version "5.0.0" fails.
`if [ "${FILEBEAT_TEMPLATE_BRANCH}" == "${WAZUH_MASTER_VERSION}" ]; then'
changed to
'if [ "${FILEBEAT_TEMPLATE_BRANCH}" = "${WAZUH_MASTER_VERSION}" ]; then'
The text was updated successfully, but these errors were encountered: