Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the new vulnerability scanner efficacy tests to make them more flexible #23472

Open
3 tasks done
pereyra-m opened this issue May 16, 2024 · 2 comments · May be fixed by #23517
Open
3 tasks done

Improve the new vulnerability scanner efficacy tests to make them more flexible #23472

pereyra-m opened this issue May 16, 2024 · 2 comments · May be fixed by #23517
Assignees
@pereyra-m
Labels
level/task type/maintenance Maintenance issues.

Comments

@pereyra-m
Copy link
Member

pereyra-m commented May 16, 2024 •
edited

Description

The refactored vulnerability scanner has a QA Python test designed to verify the proper behavior of the module with different inputs. The output in case of failure was improved at #23226.

But during the development of new cases at #23225, at least the following weak points were found:

  • If new content is required for the tests, the Python script forces to decompress it first
  • Each test is independent, but they can't be run on demand, all of them must be executed

To reduce the required time to develop new cases, the test should be improved.

DoD

  • Improve the Python test for the described weak points
  • Analyze if there are more aspects to update
  • Show the results and document the changes
@pereyra-m pereyra-m added level/task type/maintenance Maintenance issues. labels May 16, 2024
@pereyra-m pereyra-m self-assigned this May 16, 2024
@pereyra-m pereyra-m linked a pull request May 18, 2024 that will close this issue
Draft
1 task
@pereyra-m pereyra-m linked a pull request May 18, 2024 that will close this issue
Improve vulnerability scanner local component test execution #23517
Draft
1 task
@sebasfalcone

This comment was marked as off-topic.

Sign in to view
@sebasfalcone
Copy link
Member

sebasfalcone commented May 24, 2024 •
edited

Issue on hold

Awaiting for an in-depth review to apply these changes

A lot of refactoring on critical tests was performed, but we considered it necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pereyra-m pereyra-m

Labels
level/task type/maintenance Maintenance issues.
Projects
Release 5.0.0
Status: On hold
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve vulnerability scanner local component test execution wazuh/wazuh
2 participants
@sebasfalcone @pereyra-m