Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connexion 3.0 failed AIT tests #23514

Merged

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented May 17, 2024

Related issue
Closes #23389

Description

Disables wazuh-modulesd debug mode, downloads VD content at compile time to avoid performance degradation during the tests and modifies the agent RBAC tests to not check for the exact IDs when an operation is performed on all agents.

It is likely that the rootcheck test will fail because of what has been mentioned here. To be fixed in #23477.

API AIT failed because it was executed without the changes from wazuh/qa-integration-framework#154.

Tests

test_rbac_white_agent_endpoints.tavern.yaml
(venv) gasti@gasti:~/work/wazuh/api/test/integration$ pytest -vv --disable-warnings test_rbac_white_agent_endpoints.tavern.yaml --nobuild
==================================================================================================== test session starts =====================================================================================================
platform linux -- Python 3.10.14, pytest-7.3.1, pluggy-1.5.0 -- /home/gasti/work/wazuh/venv/bin/python
cachedir: .pytest_cache
metadata: {'Python': '3.10.14', 'Platform': 'Linux-6.1.0-21-amd64-x86_64-with-glibc2.36', 'Packages': {'pytest': '7.3.1', 'pluggy': '1.5.0'}, 'Plugins': {'asyncio': '0.18.1', 'tavern': '1.23.5', 'html': '2.1.1', 'metadata': '3.1.1', 'anyio': '4.1.0', 'trio': '0.8.0', 'aiohttp': '1.0.4'}}
rootdir: /home/gasti/work/wazuh/api/test/integration
configfile: pytest.ini
plugins: asyncio-0.18.1, tavern-1.23.5, html-2.1.1, metadata-3.1.1, anyio-4.1.0, trio-0.8.0, aiohttp-1.0.4
asyncio: mode=auto
collected 41 items                                                                                                                                                                                                           

test_rbac_white_agent_endpoints.tavern.yaml::GET /agents PASSED                                                                                                                                                        [  2%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents?agents_list=agent_id PASSED                                                                                                                                   [  4%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/config/{component}/{configuration} PASSED                                                                                                          [  7%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/group/is_sync PASSED                                                                                                                               [  9%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/key PASSED                                                                                                                                         [ 12%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/daemons/stats PASSED                                                                                                                               [ 14%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/stats/{component} PASSED                                                                                                                           [ 17%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /groups PASSED                                                                                                                                                        [ 19%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /groups/{group_id}/agents PASSED                                                                                                                                      [ 21%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /groups/{group_id}/configuration PASSED                                                                                                                               [ 24%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /groups/{group_id}/files PASSED                                                                                                                                       [ 26%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /groups/{group_id}/files/{filename} PASSED                                                                                                                            [ 29%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents?name=agent_name PASSED                                                                                                                                        [ 31%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/no_group PASSED                                                                                                                                               [ 34%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/outdated PASSED                                                                                                                                               [ 36%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/stats/distinct PASSED                                                                                                                                         [ 39%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/summary/status PASSED                                                                                                                                         [ 41%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/summary/os PASSED                                                                                                                                             [ 43%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /agents/{agent_id}/group/{group_id} PASSED                                                                                                                         [ 46%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /agents/{agent_id}/group PASSED                                                                                                                                    [ 48%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /agents/group?group_id={group_id} PASSED                                                                                                                           [ 51%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /groups?groups_list={group_id} PASSED                                                                                                                              [ 53%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /groups PASSED                                                                                                                                                     [ 56%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /agents?agents_list=agent_id&status=all PASSED                                                                                                                     [ 58%]
test_rbac_white_agent_endpoints.tavern.yaml::DELETE /agents  PASSED                                                                                                                                                     [ 60%]
test_rbac_white_agent_endpoints.tavern.yaml::POST /agents PASSED                                                                                                                                                       [ 63%]
test_rbac_white_agent_endpoints.tavern.yaml::POST /agents/insert PASSED                                                                                                                                                [ 65%]
test_rbac_white_agent_endpoints.tavern.yaml::POST /agents/insert/quick PASSED                                                                                                                                          [ 68%]
test_rbac_white_agent_endpoints.tavern.yaml::POST /groups PASSED                                                                                                                                                       [ 70%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/group PASSED                                                                                                                                                  [ 73%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /groups/{group_id}/configuration PASSED                                                                                                                               [ 75%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/group/{group_id}/restart PASSED                                                                                                                               [ 78%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/reconnect PASSED                                                                                                                                              [ 80%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/restart PASSED                                                                                                                                                [ 82%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/{agent_id}/group/{group_id} PASSED                                                                                                                            [ 85%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/{agent_id}/restart PASSED                                                                                                                                     [ 87%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/upgrade PASSED                                                                                                                                                [ 90%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/upgrade_custom PASSED                                                                                                                                         [ 92%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents/upgrade_result PASSED                                                                                                                                         [ 95%]
test_rbac_white_agent_endpoints.tavern.yaml::GET /agents (deny cluster:read) PASSED                                                                                                                                    [ 97%]
test_rbac_white_agent_endpoints.tavern.yaml::PUT /agents/node/{node_id}/restart PASSED                                                                                                                                 [100%]

======================================================================================== 41 passed, 42 warnings in 741.29s (0:12:21) =========================================================================================
test_rbac_black_agent_endpoints.tavern.yaml
(venv) gasti@gasti:~/work/wazuh/api/test/integration$ pytest -vv --disable-warnings test_rbac_black_agent_endpoints.tavern.yaml --nobuild
==================================================================================================== test session starts =====================================================================================================
platform linux -- Python 3.10.14, pytest-7.3.1, pluggy-1.5.0 -- /home/gasti/work/wazuh/venv/bin/python
cachedir: .pytest_cache
metadata: {'Python': '3.10.14', 'Platform': 'Linux-6.1.0-21-amd64-x86_64-with-glibc2.36', 'Packages': {'pytest': '7.3.1', 'pluggy': '1.5.0'}, 'Plugins': {'asyncio': '0.18.1', 'tavern': '1.23.5', 'html': '2.1.1', 'metadata': '3.1.1', 'anyio': '4.1.0', 'trio': '0.8.0', 'aiohttp': '1.0.4'}}
rootdir: /home/gasti/work/wazuh/api/test/integration
configfile: pytest.ini
plugins: asyncio-0.18.1, tavern-1.23.5, html-2.1.1, metadata-3.1.1, anyio-4.1.0, trio-0.8.0, aiohttp-1.0.4
asyncio: mode=auto
collected 41 items                                                                                                                                                                                                           

test_rbac_black_agent_endpoints.tavern.yaml::GET /agents PASSED                                                                                                                                                        [  2%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents?agents_list=agent_id PASSED                                                                                                                                   [  4%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/config/{component}/{configuration} PASSED                                                                                                          [  7%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/group/is_sync PASSED                                                                                                                               [  9%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/key PASSED                                                                                                                                         [ 12%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/daemons/stats PASSED                                                                                                                               [ 14%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/{agent_id}/stats/{component} PASSED                                                                                                                           [ 17%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /groups PASSED                                                                                                                                                        [ 19%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /groups/{group_id}/agents PASSED                                                                                                                                      [ 21%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /groups/{group_id}/configuration PASSED                                                                                                                               [ 24%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /groups/{group_id}/files PASSED                                                                                                                                       [ 26%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /groups/{group_id}/files/{filename} PASSED                                                                                                                            [ 29%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents?name=agent_name PASSED                                                                                                                                        [ 31%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/no_group PASSED                                                                                                                                               [ 34%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/outdated PASSED                                                                                                                                               [ 36%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/stats/distinct PASSED                                                                                                                                         [ 39%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/summary/status PASSED                                                                                                                                         [ 41%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/summary/os PASSED                                                                                                                                             [ 43%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents/upgrade_result PASSED                                                                                                                                         [ 46%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE /agents/{agent_id}/group/{group_id} PASSED                                                                                                                         [ 48%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE /agents/{agent_id}/group PASSED                                                                                                                                    [ 51%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE /agents/group?group_id=group_id PASSED                                                                                                                             [ 53%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE groups?groups_list=group_id PASSED                                                                                                                                 [ 56%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE /groups PASSED                                                                                                                                                     [ 58%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE /agents?agents_list=agent_id PASSED                                                                                                                                [ 60%]
test_rbac_black_agent_endpoints.tavern.yaml::DELETE /agents PASSED                                                                                                                                                     [ 63%]
test_rbac_black_agent_endpoints.tavern.yaml::POST /agents PASSED                                                                                                                                                       [ 65%]
test_rbac_black_agent_endpoints.tavern.yaml::POST /agents/insert PASSED                                                                                                                                                [ 68%]
test_rbac_black_agent_endpoints.tavern.yaml::POST /agents/insert/quick PASSED                                                                                                                                          [ 70%]
test_rbac_black_agent_endpoints.tavern.yaml::POST /groups PASSED                                                                                                                                                       [ 73%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/group?group_id={group_id} PASSED                                                                                                                              [ 75%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /groups/{group_id}/configuration PASSED                                                                                                                               [ 78%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/group/{group_id}/restart PASSED                                                                                                                               [ 80%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/reconnect PASSED                                                                                                                                              [ 82%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/restart PASSED                                                                                                                                                [ 85%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/{agent_id}/group/{group_id} PASSED                                                                                                                            [ 87%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/{agent_id}/restart PASSED                                                                                                                                     [ 90%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/upgrade PASSED                                                                                                                                                [ 92%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/upgrade_custom PASSED                                                                                                                                         [ 95%]
test_rbac_black_agent_endpoints.tavern.yaml::GET /agents (allow cluster:read) PASSED                                                                                                                                   [ 97%]
test_rbac_black_agent_endpoints.tavern.yaml::PUT /agents/node/{node_id}/restart PASSED                                                                                                                                 [100%]

======================================================================================== 41 passed, 42 warnings in 718.87s (0:11:58) =========================================================================================

@GGP1 GGP1 self-assigned this May 17, 2024
@GGP1 GGP1 linked an issue May 17, 2024 that may be closed by this pull request
@Selutario Selutario force-pushed the epic/20748-upgrade-to-connexion-3 branch from ecbf079 to 548f612 Compare May 23, 2024 12:35
@GGP1 GGP1 force-pushed the fix/23389-failed-ait-tests branch from 9cb8622 to 1ac8980 Compare May 24, 2024 11:10
Copy link
Member

@nico-stefani nico-stefani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, although there is one problem yet

api/test/integration/conftest.py Outdated Show resolved Hide resolved
@Selutario Selutario merged commit 3db1497 into epic/20748-upgrade-to-connexion-3 May 27, 2024
1 of 2 checks passed
@Selutario Selutario deleted the fix/23389-failed-ait-tests branch May 27, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate errors Endpoints IT for Connexion
3 participants