Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trap and set an output exit code for use by the caller #2633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

trap and set an output exit code for use by the caller #2633

wants to merge 1 commit into from

Conversation

jingles
Copy link

@jingles jingles commented Mar 27, 2024 •
edited

Description:

Adds an exit code output to the github action.

#2622

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@jingles jingles requested a review from a team as a code owner March 27, 2024 17:41
@rosecodym
Copy link
Contributor

@ahrav @joeleonjr am I correct in recalling that this is either something we intended to do or something that we specifically avoided doing for some reason?

@jingles jingles force-pushed the issue-2622-github-action-report-exit-status branch from efe6aea to 639c395 Compare March 28, 2024 13:42
@jingles jingles force-pushed the issue-2622-github-action-report-exit-status branch from 639c395 to b633f34 Compare April 9, 2024 13:20
@joeleonjr
Copy link
Contributor

@ahrav @joeleonjr am I correct in recalling that this is either something we intended to do or something that we specifically avoided doing for some reason?

I'm not sure why we couldn't make the error code available as part of the job outputs. I tested a basic workflow with this change and it doesn't seem to have any impact if you're not using the job outputs. Assuming it's helpful for the author and others, it seems like an easy change. Only possible suggestion or consideration is the name for the job id. I'm not sure if that could break anything for other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jingles @rosecodym @joeleonjr