-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for case insensitive name cache in BigQuery #21988
Open
ebyhr
wants to merge
2
commits into
master
Choose a base branch
from
ebi/metadata-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
May 16, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
wendigo
reviewed
May 20, 2024
@@ -113,9 +116,19 @@ public BigQueryClient( | |||
.expireAfterWrite(metadataCacheTtl.toMillis(), MILLISECONDS) | |||
.shareNothingWhenDisabled() | |||
.build(CacheLoader.from(this::listDatasetIdsFromBigQuery)); | |||
this.remoteDatasetCaseInsentiveCache = buildCache(caseInsensitiveNameMatchingCacheTtl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need two separate caches if they have same ttl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean merging remoteDatasetCaseInsentiveCache
& remoteDatasetIdCache
into one?
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/metadata-cache
branch
8 times, most recently
from
May 22, 2024 22:59
e8e1c83
to
2998aba
Compare
findinpath
reviewed
May 23, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
findinpath
reviewed
May 23, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Show resolved
Hide resolved
Co-authored-by: regadas <oss@regadas.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #19624
Fixes #10740
Test on a schema with 180 tables:
Release notes
(x) Release notes are required, with the following suggested text: