List encrypted archive entries, if available, in SevenZipParser (#1574) #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @tc-wleite!
Sure, I can try to take a look. |
|
Sorry, I used a wrong issue number in an unrelated commit message (and master branch is protected). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a partial solution for #1574, as it handles only RAR files.
ZIP and 7Z would need to be handled in
PackageParserclass.I guess that another possibility would be using a multiple parser.
@lfcnassif, I tried a few things in
PackageParserclass and using a multiple parser, but in both cases there were some ugly side effects, so I kept just the changes inSevenZipParser.Maybe you can see an easier way of listing the entries, as you are familiar with that classes.
Another possible approach would be support just RAR files (through this PR) and leave ZIP/7Z as a future improvement.