Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing Item Properties #1501

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

FelipeFcosta
Copy link
Contributor

closes #52 and #286

@FelipeFcosta FelipeFcosta marked this pull request as draft February 2, 2023 18:23
@FelipeFcosta
Copy link
Contributor Author

Hi @lfcnassif, #52 and #286 may be almost finished here, but needs testing to see if this doesn't mess with previous working UI behaviour. It still has no limit to how many properties a user can choose for the html report, what should be the maximum?

@lfcnassif
Copy link
Member

Hi @lfcnassif, #52 and #286 may be almost finished here, but needs testing to see if this doesn't mess with previous working UI behaviour. It still has no limit to how many properties a user can choose for the html report, what should be the maximum?

Thank you @FelipeFcosta! I'm not sure, maybe 100? Or maybe we could make it configurable in HtmlReportConfig.txt. Any opinion @tc-wleite?

@wladimirleite
Copy link
Member

I'm not sure, maybe 100? Or maybe we could make it configurable in HtmlReportConfig.txt. Any opinion @tc-wleite?

I am also not sure, but I think it is fine to have a hard coded limit like 100. I guess too many columns would make the report very hard to read.

@FelipeFcosta
Copy link
Contributor Author

FelipeFcosta commented Feb 10, 2023

I added the 100 properties limit for the HTML report and the other functionalities. I think it's ready for review @lfcnassif

@FelipeFcosta FelipeFcosta marked this pull request as ready for review February 10, 2023 18:03
@lfcnassif
Copy link
Member

Thank you @FelipeFcosta! I'll review this after 4.1 release, let's put this in 4.2.

@patrickdalla
Copy link
Collaborator

For CSV export, I think there should be some basic metadata list, like "basicReportProps" in HTMLReportTask. Could be the same. These should always be exported, or, at least, a button to select them all should exists, like there is a button to 'select/ unselect all'. Maybe another checkbox with the name 'select/ unselect all basic props'.

@patrickdalla
Copy link
Collaborator

In the HTML report, the bookmark file list was show as bellow:
image

@lfcnassif
Copy link
Member

Isn't it replacing the tags? Could you fix it?

@patrickdalla
Copy link
Collaborator

Yes. I am fixing.

@patrickdalla
Copy link
Collaborator

It seems the problem was with my test config/environment.

@patrickdalla
Copy link
Collaborator

Yes. The problem was that I should had updated the templates of my case folder. It is working.

@patrickdalla
Copy link
Collaborator

Well, it seems it is working.

I just want to make some suggestion, maybe to become new issue:

  • It could possible to select properties per bookmark?
  • There couldn't be predefined metadatas per category? For example, exif make and model could be exported by default in the image, when viewing in the respective image category page.

@lfcnassif
Copy link
Member

Those are good ideas, we just need to prioritize them looking at all other open issues...

Are selected properties being saved in user.dir to be reused between different cases? If yes, user could select his preferred property set and the module could simply skip them if the specific item doesn't have the property, so a single list could work for all bookmarks/categories.

@patrickdalla
Copy link
Collaborator

patrickdalla commented Apr 5, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to choose file properties to include in HTML report
4 participants