Improve the way to get default gateway on macOS #1379
Conversation
There was a problem hiding this comment.
Thanks @zhengfeihe, it's a good start.
Could you address all comments on the PR, add a few remarks for the code, and add some testing for the PR?
Pcap++/src/PcapLiveDevice.cpp
Outdated
| { | ||
| PCPP_LOG_DEBUG("Error retrieving default gateway address: couldn't get netstat output"); | ||
|
|
||
| #define ROUNDUP(a) \ |
There was a problem hiding this comment.
use #undef after the usage of the macro
|
@zhengfeihe next time don't resolve the issue yourself, so other people can easily track the issues. Also, could you let the tests pass? |
Thanks for the reminder. I will watch out next time. |
| //route message struct for communication in BSD / APPLE device | ||
| struct BSDRoutingMessage{ | ||
| struct rt_msghdr header; | ||
| char messageSpace[512]; |
There was a problem hiding this comment.
wondering if 512 is a proper number?
| return ; | ||
| } | ||
|
|
||
| bzero((char *)&routingMessage, sizeof(routingMessage)); |
There was a problem hiding this comment.
let's use reinterpret_cast here.
|
@zhengfeihe As we previously discussed, it appears that FreeBSD cannot easily share its implementation with macOS. Therefore, let's separate the FreeBSD implementation from macOS, allowing the macOS implementation to be merged first. |
Implement thoughts from #1355
Follow the source code of route on a Mac to use a raw socket for retrieving default gateway information from the routing table, thus eliminating the need for system calls.
Test will be added accordingly.