Close PromQL engine when Prometheus exits #14064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13becbb
to
418b374
Compare
161649a
to
69e96c4
Compare
fec9def
to
f117bef
Compare
f117bef
to
1a8c085
Compare
1a8c085
to
746bb34
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
746bb34
to
0cc99e6
Compare
|
@machine424 are you planning to review this? |
I wasn't aware of this, but I'm happy to review when it's ready ;) |
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
8899476
to
e57aac8
Compare
|
@machine424 I pushed a fix for a minor omission during my resolution of merge conflicts. The PR should be ready for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the PromQL engine, so resources can be released, when Prometheus exits. Follow-up to #14000.
I raised this issue in a Prometheus contributors sync, and @beorn7 thought it couldn't hurt to free the engine's resources on program exit/test cleanup :)