pkg/config: support seconds in pprof configuration #4623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brancz, i just wanted to bump this up to get some eyes on it; could you please take a look for add folks who would be able to review? thank you. |
|
Apologies for missing this, this looks great! |
brancz
reviewed
May 29, 2024
brancz
reviewed
May 29, 2024
|
I'm really sorry, this needs a rebase, but otherwise lgtm! And sorry again for this slipping through the cracks, so thank you for pinging me again. In the future also feel free to ping me on the Parca Discord server if you want to make sure to get a faster review! :) |
this updates the definition of `PprofProfilingConfig` such that a new integer field `Seconds` is added which can be set for profiles. additionally, it changes the behavior where setting any profiling configurations will end up overriding the default so merge will now become a replace. seconds is accepted as a query parameter and with this change, when provided, it will be used as scraping duration rather than the scraping interval value. this allows having scraping where process being profiled isn't under constant profiling. this only applies to configurations that have delta enabled. https://pkg.go.dev/net/http/pprof
1450407
to
8e7f9ab
Compare
|
thanks for taking a look, @brancz. i rebased and addressed the feedback. PTAL when you get a chance. |
brancz
approved these changes
Jun 3, 2024
brancz
reviewed
Jun 3, 2024
|
@brancz i think i need one last approval before checks are executed? |
|
Thank you for the awesome contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates the definition of
PprofProfilingConfigsuch that a new integer fieldSecondsis added which can be set for profiles, in an attempt to resolve #2818.additionally, it changes the behavior where setting any profiling configurations will end up overriding the default so merge will now become a replace.
seconds is accepted as a query parameter and with this change, when provided, it will be used as scraping duration rather than the scraping interval value. this allows having scraping where process being profiled isn't under constant profiling. this only applies to configurations that have delta enabled.
https://pkg.go.dev/net/http/pprof