Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Summoning abilities don't activate when reloading a session. #1005

Open
0zuzu opened this issue May 17, 2024 · 2 comments
Open

Bug: Summoning abilities don't activate when reloading a session. #1005

0zuzu opened this issue May 17, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@0zuzu
Copy link
Contributor

0zuzu commented May 17, 2024

When reloading a session (battle), the game only activates summoning abilities like Drought, Intimidate, etc if they meet one of these 3 criteria:

  • The battle is a trainer battle.
  • It's the first wave of a biome for classic mode standards (1, 11, 21, etc)
  • The battle wasn't loaded from the menu

This logic doesn't include all scenarios where summoning abilities should trigger, like going from a single to a double battle or changing biomes in endless where it can happen on nearly any floor.

It's also built on a flaw: When reloading a session, all Pokemon on the field are sent out, including the ones who were supposed to already be there.

To fix this issue, I propose storing the current allied Pokemons on the field when saving a session. Then, when loading it, only activate summoning abilities of the Pokemon who weren't on the field when the session was saved.

This, together with #694 should fix most if not all bugs pertaining to reloading sessions.

Drought and Psychic surge are both activated when switching biomes in endless:
image

After reloading the fight neither activate:
image

@Madmadness65 Madmadness65 added the Bug Something isn't working label May 17, 2024
@happinyz
Copy link
Contributor

I have a PR to address this: #694

@0zuzu
Copy link
Contributor Author

0zuzu commented May 17, 2024

I have a PR to address this: #694

This bug is mainly centered around summoning abilities being ignored when reloading a session. It's not just about battle tags not being saved in a session. But together with your PR it should solve most if not all problems with loading a session.

@0zuzu 0zuzu changed the title Bug: Weather/Terrain Abilities don't trigger on session load Bug: Summoning abilities don't activate when reloading a session. May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants