-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: OrtConfiguration: Introduce connections map to centralize StorageConnections #5516
Draft
bs-ondem
wants to merge
5
commits into
oss-review-toolkit:main
Choose a base branch
from
bosch-io:storage-connections
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs-ondem
changed the title
OrtConfiguration: Introduce connections map for centralizing StorageConnections
OrtConfiguration: Introduce connections map to centralize StorageConnections
Jul 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #5516 +/- ##
============================================
- Coverage 57.66% 57.47% -0.19%
Complexity 2190 2190
============================================
Files 321 324 +3
Lines 18989 19059 +70
Branches 3730 3739 +9
============================================
+ Hits 10950 10955 +5
- Misses 6898 6964 +66
+ Partials 1141 1140 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bs-ondem
changed the title
OrtConfiguration: Introduce connections map to centralize StorageConnections
WIP: OrtConfiguration: Introduce connections map to centralize StorageConnections
Jul 4, 2022
bs-ondem
force-pushed
the
storage-connections
branch
from
September 16, 2022 08:47
ac77ee3
to
1dc9810
Compare
Signed-off-by: Onur Demirci <onur.demirci@bosch.io>
Signed-off-by: Onur Demirci <onur.demirci@bosch.io>
Signed-off-by: Onur Demirci <onur.demirci@bosch.io>
bs-ondem
force-pushed
the
storage-connections
branch
from
September 16, 2022 15:05
1dc9810
to
a1aeaaf
Compare
…rage Signed-off-by: Onur Demirci <onur.demirci@bosch.io>
…esStorage Signed-off-by: Onur Demirci <onur.demirci@bosch.io>
bs-ondem
force-pushed
the
storage-connections
branch
from
September 20, 2022 13:31
a1aeaaf
to
dd60abf
Compare
@bs-ondem, @mnonnenmacher, @MarcelBochtler, are there any plans to finish the work on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request adheres to our contribution guidelines. Thank you!