Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FossID: Scanner option fetchSnippetMatchedLines should be removed #8647

Open
nnobelis opened this issue May 15, 2024 · 0 comments
Open

FossID: Scanner option fetchSnippetMatchedLines should be removed #8647

nnobelis opened this issue May 15, 2024 · 0 comments
Labels
enhancement Issues that are considered to be enhancements to triage Issues that need triaging

Comments

@nnobelis
Copy link
Member

Due to changes in ORT (#7401), the snippets results are now grouped by source line ranges.
Therefore, missing the matched lines information does not make sense if one wants to work with snippets.

I suggest we remove this option and always assume it's true.
This call is expensive though since one such request is made per snippet, but hopefully it will be better when FossID change it's API to an OPENAPI-compliant one.
@nnobelis nnobelis added enhancement Issues that are considered to be enhancements to triage Issues that need triaging labels May 15, 2024
@sschuberth sschuberth changed the title FossID: Scammer option fetchSnippetMatchedLines should be removed FossID: Scanner option fetchSnippetMatchedLines should be removed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues that are considered to be enhancements to triage Issues that need triaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nnobelis