Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note: The cpuid table is x86 only #7462

Closed
directionless opened this issue Jan 26, 2022 · 4 comments
Closed

Note: The cpuid table is x86 only #7462

directionless opened this issue Jan 26, 2022 · 4 comments
Labels
apple_silicon blueprint Blueprints. For details see CONTRIBUTING.md. deprecation Relating to function deprecation

Comments

@directionless
Copy link
Member

I think we expected to need to drop some tables with m1 support, but I don't remember if the cpuid table was one. Is this intentional?

@alessandrogario
Copy link
Member

I think we expected to need to drop some tables with m1 support, but I don't remember if the cpuid table was one. Is this intentional?

Yes this is intentional and is also missing from the Linux AArch64 port we used for Graviton; the cpuid instruction used in the implementation file is Intel-specific, and there is not a direct replacement.

@mike-myers-tob
Copy link
Member

Let's make sure this is mentioned in the changelog, as an x86-specific table, with columns that directly return values from the CPUID assembly instruction.

Optionally, do we want to create a new table that is cross-architecture and doesn't have an x86-specific schema? Could be a blueprint issue.

@directionless directionless added deprecation Relating to function deprecation blueprint Blueprints. For details see CONTRIBUTING.md. and removed bug labels Feb 3, 2022
@directionless directionless changed the title Apple M1 support dropped the cpuid table Note: The cpuid table is x86 only Feb 3, 2022
@directionless
Copy link
Member Author

If this is an x86 specific instruction, I think it's reasonable to either drop the table, or to have it return no data on other architectures. I'm always torn between not having a table, which feels correct, and making it easier to work with osquery.

I suspect we should add an empty table, but I don't think it needs to be release blocking.

I'm also not sure if it's the same, but I see that arm does have some CPUID registers

@directionless directionless removed this from the 5.2.2 milestone Feb 3, 2022
@directionless
Copy link
Member Author

We stopped shipping this on m1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple_silicon blueprint Blueprints. For details see CONTRIBUTING.md. deprecation Relating to function deprecation
Projects
None yet
Development

No branches or pull requests

3 participants