Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTLS 1.3: Resolve cookie test todo #24425

Closed
wants to merge 3 commits into from
Closed

DTLS 1.3: Resolve cookie test todo #24425

wants to merge 3 commits into from

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented May 16, 2024

  • tests are added or updated

@fwh-dc
Copy link
Contributor Author

fwh-dc commented May 16, 2024

@t8m @mattcaswell this one is ready for review

@t8m t8m added approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature tests: present The PR has suitable tests present labels May 17, 2024
mattcaswell
mattcaswell requested changes May 17, 2024
View reviewed changes
test/dtlstest.c Outdated Show resolved Hide resolved
@fwh-dc fwh-dc requested a review from mattcaswell May 17, 2024 12:06
mattcaswell
mattcaswell requested changes May 17, 2024
View reviewed changes
test/dtlstest.c Outdated Show resolved Hide resolved
test/dtlstest.c Outdated Show resolved Hide resolved
test/dtlstest.c Outdated Show resolved Hide resolved
@fwh-dc fwh-dc requested review from mattcaswell and t8m May 17, 2024 15:14
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 20, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 21, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented May 22, 2024

Merged to the feature branch. Thank you for your contribution.

@t8m t8m closed this May 22, 2024
openssl-machine pushed a commit that referenced this pull request May 22, 2024
@fwh-dc @t8m
Run test_cookie() test with DTLS 1.3
5cbb538 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge tests: present The PR has suitable tests present triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwh-dc @openssl-machine @t8m @mattcaswell