Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate the memory limits of functions in the REST API #177

Open
alexellis opened this issue May 19, 2021 · 4 comments
Open

Populate the memory limits of functions in the REST API #177

alexellis opened this issue May 19, 2021 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alexellis
Copy link
Member

alexellis commented May 19, 2021 •
edited

Expected Behaviour

When users list or query functions from the REST API, then the memory limits set on the functions should be returned in the JSON response.

Current Behaviour

They are being accepted upon deployment, but not being populated when querying.

List all Possible Solutions

Try to read back from the task or container definition.

Update here:

https://github.com/openfaas/faasd/blob/master/pkg/provider/handlers/functions.go

https://github.com/openfaas/faasd/blob/master/pkg/provider/handlers/read.go

Context

Required for terraform provider and API compliance.
@developer-guy
Copy link

I would like to do that, if no one wants to 🙋🏻‍♂️

@alexellis
Copy link
Member Author

Given how long has passed since you volunteered to help, this issue is now fair game for anyone who wants to contribute.

Nobody is working on this at present.

@alexellis
Copy link
Member Author

/add label: help wanted, good first issue

@derek derek bot added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2021
@alexellis
Copy link
Member Author

@Shikachuu I don't think we have any CPU limits at this stage, so this just covers memory being populated back again from what was inputted.

See also: 9e5eb84

@Shikachuu Shikachuu mentioned this issue Sep 18, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexellis @developer-guy