Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify safetensors reading #4543

Merged
merged 1 commit into from
May 21, 2024
Merged

simplify safetensors reading #4543

merged 1 commit into from
May 21, 2024

Conversation

mxyng
Copy link
Contributor

@mxyng mxyng commented May 20, 2024 •
edited

mapstructure is unnecessary and the safetensors header can be read directly into a struct

@mxyng mxyng force-pushed the pdevine/llama3 branch 3 times, most recently from 0a7d4fb to 2bf8089 Compare May 20, 2024 20:29
@mxyng mxyng force-pushed the mxyng/simple-safetensors branch from 1f79543 to 0a7d4fb Compare May 20, 2024 20:30
@jmorganca jmorganca requested a review from pdevine May 20, 2024 21:18
@mxyng mxyng force-pushed the pdevine/llama3 branch 2 times, most recently from 5923794 to 722cba2 Compare May 20, 2024 23:14
@mxyng mxyng force-pushed the mxyng/simple-safetensors branch from 0a7d4fb to bd2a02a Compare May 20, 2024 23:14
@mxyng mxyng force-pushed the mxyng/simple-safetensors branch from bd2a02a to 171eb04 Compare May 21, 2024 18:28
Base automatically changed from pdevine/llama3 to main May 21, 2024 21:43
@mxyng mxyng merged commit a6d0f44 into main May 21, 2024
15 checks passed
@mxyng mxyng deleted the mxyng/simple-safetensors branch May 21, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorganca jmorganca jmorganca approved these changes

@pdevine pdevine Awaiting requested review from pdevine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxyng @jmorganca