Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GFX h264 software via --enable-x264 #3073

Merged
merged 9 commits into from
May 28, 2024
Merged

Conversation

jsorg71
Copy link
Contributor

@jsorg71 jsorg71 commented May 14, 2024

No description provided.

Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor observations.

xrdp/xrdp_encoder_x264.c Outdated Show resolved Hide resolved
common/xrdp_client_info.h Outdated Show resolved Hide resolved
@Nexarian
Copy link
Contributor

Fix the merge conflict, then I have no further objections.

@jsorg71
Copy link
Contributor Author

jsorg71 commented May 22, 2024

Sure, I'll rebase and fix that up.
I'm also thinking about adding a xrdp.ini setting for prefer h264 over progressive. Currently, if the client supports h264, it's used.

@Nexarian
Copy link
Contributor

We do need a setting to allow users to select which protocol they want to use. Strictly speaking, they should also be able to select RLE (non-GFX) as well...

@jsorg71 jsorg71 merged commit 00332ac into neutrinolabs:devel May 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants