Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

go.mod controlplane/v0.3.0 #2157

Open
adrianlzt opened this issue May 18, 2020 · 4 comments
Open

go.mod controlplane/v0.3.0 #2157

adrianlzt opened this issue May 18, 2020 · 4 comments
Labels
bug 🐛 Something isn't working pinned Pin for stale-pod

Comments

@adrianlzt
Copy link

Expected Behavior

Go get working properly

Current Behavior

Getting the module github.com/networkservicemesh/networkservicemesh/k8s produces an error.

Is it an error to point to version 0.3.0? I don't see a tag for that version in this repo.

And the use of replace in go.mod instead of specifying the versions, is that "normal"?

Steps to Reproduce

➜ go get github.com/networkservicemesh/networkservicemesh/k8s
go: github.com/networkservicemesh/networkservicemesh/k8s upgrade => v0.0.0-20200513050041-9a17692e4a5b
go get: github.com/networkservicemesh/networkservicemesh/k8s@v0.0.0-20200513050041-9a17692e4a5b requires
        github.com/networkservicemesh/networkservicemesh/controlplane@v0.3.0: reading github.com/networkservicemesh/networkservicemesh/controlplane/controlplane/go.mod at revision controlplane/v0.3.0: unknown revision controlplane/v0.3.0
@denis-tingaikin denis-tingaikin added the bug 🐛 Something isn't working label May 18, 2020
@denis-tingaikin
Copy link
Member

denis-tingaikin commented May 18, 2020

Hello @adrianlzt,
Interesting... What you want to export from pkg github.com/networkservicemesh/networkservicemesh/k8s?

@edwarnicke
Copy link
Member

@adrianlzt Ah... you are hitting the infamous "multi-module repos have subtle problems: #43" issue.

The way that go get handles downloading modules doesn't cope well at all with multiple go modules in the same repo cross-referring to each other using local replaces. Its part of why we are in the process of migrating to a multi repo approach.

What's the underlying thing you are trying to achieve?

@adrianlzt
Copy link
Author

Trying to compile https://github.com/skydive-project/skydive-plugins
That after removing an erroneous replace (first one) tries to download github.com/skydive-project/skydive that have several deps with networkservicemesh.

I was trying to clean (remove) all those replaces so I tried with an empty go.mod and then I saw this.

Looks like kubernetes has fixed some of the problems with go.mod: kubernetes/kubernetes#79384

@edwarnicke edwarnicke added this to To do in Issue/PR tracking via automation May 19, 2020
@stale
Copy link

stale bot commented Jun 17, 2020

This issue has been automatically marked as stale because it has not had activity in 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 17, 2020
@edwarnicke edwarnicke added pinned Pin for stale-pod and removed wontfix This will not be worked on labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 Something isn't working pinned Pin for stale-pod
Projects
Issue/PR tracking
  
Backlog
Development

No branches or pull requests

3 participants