Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPG signing + remove some triggers in Update References workflow #11594

Closed
wants to merge 2 commits into from
Closed

Add GPG signing + remove some triggers in Update References workflow #11594

wants to merge 2 commits into from

Conversation

NikitaSkrynnik
Copy link
Collaborator

Descrption

To make GPG signing work we need to:

  1. Create gpg keys with a passphrase, name == NSMBot, email == nsmbot@networkservicmesh.io
gpg --full-gen-key
  1. Export public and private keys
gpg --export -a nsmbot@networkservicmesh.io > public.gpg
gpg --export-secret-key -a nsmbot@networkservicmesh.io > private.gpg
  1. Add the public key to NSMBot GPG keys on Github
  2. Add the private key and passphrase to deployments-k8s secrets GPG_PRIVATE_KEY and GPG_PASSPHRASE

Issue link

#11593

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik
add importing gpg keys
e1c05b2 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix yaml linter issues
4f3e548 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik NikitaSkrynnik self-assigned this Apr 1, 2024
@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Apr 4, 2024
Open
@denis-tingaikin
Copy link
Member

@edwarnicke Please have a look at the suggested solution when you get a chance ☝️
Let us know when the required secrets for the NSMBot will be available or if you have any questions.

@NikitaSkrynnik NikitaSkrynnik deleted the gpg branch June 2, 2024 07:49
@NikitaSkrynnik NikitaSkrynnik restored the gpg branch June 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edwarnicke edwarnicke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NikitaSkrynnik @denis-tingaikin @edwarnicke