-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Correct comment in MenuListComposition demo #42271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neaumusic
commented
May 16, 2024
- I have followed (at least) the PR section of the contributing guide.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
…41678) Co-authored-by: Michael Li <33362998+michael-land@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
… prop even if loading is true. (mui#41677)
…alues demo so that the tooltip thumb label displays the same as the value text (mui#41679)
Co-authored-by: magnimarels <70704459+magnimarels@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…ui#41842) Co-authored-by: Andrew Cherniavskii <andrew@mui.com>
…41822) Co-authored-by: Aarón García Hervás <aaron@mui.com>
These changes should help the UX by having load times. https://app.ahrefs.com/site-audit/6343948/9/issues
…ment for small autocomplete (@TahaRhidouani) (mui#42176) Co-authored-by: Taha Rhidouani <37096708+TahaRhidouani@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
…leButtonGroupClasses type (@tarunrajput) (mui#42250) Co-authored-by: Tarun Chauhan <tarunrajput1337@gmail.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
…Mandar-Pandya) (mui#42265) Signed-off-by: Mandar-Pandya <112475099+Mandar-Pandya@users.noreply.github.com> Co-authored-by: Mandar-Pandya <112475099+Mandar-Pandya@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: James Wilson <jsw.james.wilson@gmail.com>
Netlify deploy previewhttps://deploy-preview-42271--material-ui.netlify.app/ Bundle size report |
zannager
added
docs
Improvements or additions to the documentation
component: menu
This is the name of the generic UI component, not the React module!
labels
May 17, 2024
danilo-leal
changed the title
fix(docs): correct comment in MenuListComposition demo
[material-ui][docs] Correct comment in MenuListComposition demo
May 18, 2024
Hey @neaumusic, thanks for the PR! Can you point it to the |
@neaumusic Please create a new PR pointing it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: menu
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.