[material-ui] Stabilize CssVarsProvider and extendTheme
#42246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview
@material-ui/core: parsed: +0.10% , gzip: +0.10% Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
reviewed
May 20, 2024
mnajdova
reviewed
May 20, 2024
docs/data/material/design-resources/material-ui-sync/material-ui-sync.md
Outdated
Show resolved
Hide resolved
mnajdova
approved these changes
May 20, 2024
docs/data/material/customization/css-theme-variables/overview.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/css-theme-variables/overview.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/css-theme-variables/usage/usage.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/css-theme-variables/usage/usage.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/css-theme-variables/usage/usage.md
Outdated
Show resolved
Hide resolved
docs/data/system/experimental-api/css-theme-variables/css-theme-variables.md
Outdated
Show resolved
Hide resolved
docs/data/system/experimental-api/css-theme-variables/css-theme-variables.md
Outdated
Show resolved
Hide resolved
docs/data/system/experimental-api/css-theme-variables/css-theme-variables.md
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ import { | |||
| demos, | |||
| docs, | |||
| demoComponents, | |||
| } from 'docs/data/material/experimental-api/css-theme-variables/usage/usage.md?muiMarkdown'; | |||
| } from 'docs/data/material/customization/css-theme-variables/customization.md?muiMarkdown'; | |||
There was a problem hiding this comment.
I don't love this path name: /material/customization/foobar/customization just looks weird to me with customization repeated. I'm not sure which one really needs to be replaced but it seems like this doc file name is the simpler choice.
There was a problem hiding this comment.
+1 here, too — maybe this page could be called "Customizing CSS theme variables"? Then, drop the hyphen on the title!
There was a problem hiding this comment.
I changed to "configuration", is it better?
danilo-leal
reviewed
May 20, 2024
danilo-leal
reviewed
May 20, 2024
docs/data/material/migration/migration-v5/migration-css-theme-variables.md
Outdated
Show resolved
Hide resolved
danilo-leal
reviewed
May 20, 2024
DiegoAndai
approved these changes
May 23, 2024
|
@siriwatknp this closes #41070 right? |
ad5df08
to
6156593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes