Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure starting theme #418

Open
lilyjw opened this issue Mar 24, 2022 · 1 comment
Open

Configure starting theme #418

lilyjw opened this issue Mar 24, 2022 · 1 comment
Assignees
@erinehall
Labels
enhancement New feature or request Points: 2 2 agile story points timescale/short-term Becomes timescale/imminent in weeks or months
Milestone
Version 5.1.0

Comments

@lilyjw
Copy link
Contributor

lilyjw commented Mar 24, 2022 •
edited

Hello, I'm interested in configuring my custom Navigator instance to start with a light theme, as it works better with my default layers and general website theme.

Currently on develop, it looks like the user's system settings are used to start, though it can be user-controlled via dropdown and cookie.

Would it make sense to have a config.json setting for this?

As a temporary workaround, have made the following edits to force a light theme: mitre-atlas@c931a7e

May be semi-related to #403
@clemiller
Copy link
Contributor

Hi @lilyjw,

Thanks for reaching out! I can definitely see why it might be preferable to have a configuration setting for the theme. You're correct the user's system settings are used by default and it could be useful to have the ability to override this logic.

My current thoughts are to add a theme field to the config file with the following valid options: light, dark, or system, using system as the default value. This would provide an easy way to override the theme without disrupting any existing settings. Implementation wise, this would be fairly straightforward and have little to no impact on the application. If you have any other thoughts, I'm open to suggestions!

@clemiller clemiller added enhancement New feature or request timescale/short-term Becomes timescale/imminent in weeks or months Points: 2 2 agile story points labels Apr 7, 2022
@erinehall erinehall self-assigned this Oct 5, 2023
@clemiller clemiller added this to the Version 4.10.0 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erinehall erinehall

Labels
enhancement New feature or request Points: 2 2 agile story points timescale/short-term Becomes timescale/imminent in weeks or months
Projects
None yet
Milestone
Version 5.1.0
Development

No branches or pull requests
3 participants
@lilyjw @clemiller @erinehall