-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to TAEF 10.88.240110002 #16595
base: main
Are you sure you want to change the base?
Conversation
I'm running this PR through the PGO build as well -- i will merge when it is done. @lhecker @zadjii-msft I need a re-review on the last push |
This test failure on ARM64 is durable (it keeps failing) and nonsensical. terminal/src/buffer/out/ut_textbuffer/TextAttributeTests.cpp Lines 116 to 127 in d3a18b9
Line 127 is failing, because I need to look at this on an actual ARM64 device... |
Also it only fails in release. Figures. |
Did we ever file an internal issue on the ARM codegen thing here? |
I believe it's this one: https://developercommunity.visualstudio.com/t/Bad-ARM64-codegen--maybe-during-constant/10583372 |
got it, so that's https://task.ms/dd/1969044 internally. For the sake of triaging the PR backlog, I'm gonna move this to a draft (since we can't merge till the compiler bug is fixed) |
The compiler bug reproduces in complete isolation, without TAEF. I don't think this PR caused it, it only found it. |
Stolen from PowerToys
…into dev/duhowett/taef-10.88
If this arm64 build passes, I will reupdate and ingest taef 10.92 |
The compiler bug may only be fixed by VS 17.11 (!) |
Banished back to draft status |
No description provided.