-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GarnetClient Extensions #375
Comments
/cc @TalZaccai |
Yes, we are definitely open to accepting pull requests in this space. Thanks, and look forward to it! |
Believe it or not yesterday I planned to start my library but I thought it be better to file an issue than hear the response, @badrishc could you please look for one of the extensions that I created if it's fine I can start push a PR BTW shall we add it as extension methods or where should I add them, coz it's the first time to contribute here |
These can be added at https://github.com/microsoft/garnet/tree/main/libs/client/GarnetClientAPI - you will see there are already files for different API categories, such as Sorted Set. You would add the new ones similarly. |
Got it, I will start my PRs :) One more thing but it might be breaking change why you are using |
It was just a stylistic choice. We can leave it as |
+1 for following the standardized practice in .NET of PascalCasing the namespaces. |
Feature request type
enhancement
Is your feature request related to a problem? Please describe
While there are few implemented commands for
GarnetClient
are you open to accepting PRs for implementing other commands on top ofExecuteForStringResultAsync()
orExecuteForStringArrayResultAsync()
I find myself writing some here https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/blob/main/src/OrchardCoreContrib.Garnet/Extensions/GarnetClientExtensions.cs
Also there are two in this PR https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/127/files
Describe the solution you'd like
Add extension methods to
GarnetClient
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: