Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality sharpness #126

Open
CWTakiku opened this issue Oct 8, 2023 · 19 comments
Open

Quality sharpness #126

CWTakiku opened this issue Oct 8, 2023 · 19 comments

Comments

@CWTakiku
Copy link

CWTakiku commented Oct 8, 2023

How to improve clear picture quality, adjustment does not seem to work

@mwarning
Copy link
Member

mwarning commented Oct 8, 2023

Have you tried Meshenger 4.2.4? And have you tried changing the resolution via the menu (small gear icon in the left top corner) during a call?

@CWTakiku
Copy link
Author

CWTakiku commented Oct 9, 2023

Yeah, I don't know if it's my phone's camera, but I changed it to capture and cast, and it's blurry, even though I set resolution first

@mwarning
Copy link
Member

mwarning commented Oct 9, 2023

Then it is hard to say why WebRTC cannot or won't capture a higher quality video stream.

@CWTakiku
Copy link
Author

I switched to h264 encoding and the sharpness improved a lot, but the latency issues remained

@mwarning
Copy link
Member

hm, where did you switch it to h264?

@CWTakiku
Copy link
Author

I customized the encoderFactory, which uses vp8 by default, and I changed it to h264

@mwarning
Copy link
Member

mwarning commented Oct 11, 2023

Please share you changes. Maybe it is enough to expose the vp8 and h264 setting. Then I could add those as settings.

@CWTakiku
Copy link
Author

image

@mwarning
Copy link
Member

mwarning commented Oct 12, 2023

Nice. Have you tried to just disable VP8? https://github.com/meshenger-app/meshenger-android/blob/master/app/src/main/kotlin/d/d/meshenger/call/RTCCall.kt#L531 (with enabled hardware accelaration)

@CWTakiku
Copy link
Author

Yes, it didn't work when I just set vp8 to false, I used a custom coding factory that worked, and now my picture quality and fluency have improved when I coded with h264 and reduced the frame rate, but there is a key problem that sometimes my picture gets blurry for a moment due to the webrtc strategy
image

@mwarning
Copy link
Member

Thank you. I will give it a try.

@mwarning
Copy link
Member

mwarning commented Oct 14, 2023

@CWTakiku can you try a fresh install of 48756d0 on both phones?

Btw., the video codec limit to h264 makes by phone unable to connect. I am still investigating.

@CWTakiku
Copy link
Author

CWTakiku commented Oct 16, 2023

I looked at your commit history, it seems that you did not set up a custom factory, just configured the default acceleration factory, I will provide my coding factory class for you to see
新建 文本文档 (8).txt

@mwarning
Copy link
Member

@CWTakiku thank you, I will give it a try. I did not commit my custom factory, since it broke the call feature for me.

@mwarning
Copy link
Member

I tried the code with only isSupportedH264 returning true (like in your screenshot), but now the phones cannot establish a connection.

Aside from that, the picture quality with the current master is pretty good (HD).

@CWTakiku
Copy link
Author

What you need is that both the receiver and the sender need to set up the custom encoder to establish the connection, and how does your image quality improve

@mwarning
Copy link
Member

hm, I had the same software on both devices. Here is the source code: https://github.com/meshenger-app/meshenger-android/tree/h264

@mwarning
Copy link
Member

I will do an intermediate release with enabled hardware decoding by default (it wasn't working right before). Then let's do more testing.

@CWTakiku
Copy link
Author

Ok, theoretically it's OK, but it's been proven to work on my side and has been used in my own projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants